This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Add extension method for getting environment name #194
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
| /// <returns>True if the specified name is same as the current environment.</returns> | ||
| public static bool IsEnvironment( | ||
| [NotNull]this IHostingEnvironment hostingEnvironment, | ||
| [NotNull]string environmentName) |
There was a problem hiding this comment.
Should this really throw on null?
There was a problem hiding this comment.
(string.Equals() doesn't care about null, so the rest of the code would still work just fine)
There was a problem hiding this comment.
Is null a valid environment name? I think there is always a default in hosting layer. That's why I made it throw on null.
There was a problem hiding this comment.
Yeah I'm thinking more of a mock/lazy implementation of the interface that happens to return null. Would we want that to fail?
There was a problem hiding this comment.
hmm. I think I can remove the null check on environmentName.
kirthik
added a commit
that referenced
this pull request
May 22, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #100
@rustd @muratg