This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Make sure IApplicationLifetime gets added even if startup throws. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a test |
Tratcher
force-pushed
the
tratcher/applifetime
branch
from
abda1c4 to
1f1c4b9
Compare
|
Updated |
| { | ||
| var builder = CreateWebHostBuilder(); | ||
| var serverFactory = new TestServerFactory(); | ||
| var engine = (HostingEngine)builder.UseServer(serverFactory).UseStartup<StartupCtorThrows>().Build(); |
There was a problem hiding this comment.
Some of the tests assert on non-interface members, but not this one. removed.
Tratcher
force-pushed
the
tratcher/applifetime
branch
from
1f1c4b9 to
52796a0
Compare
|
Updated. |
|
Why is travis failing? |
|
IHttpContextFactory due to the lack of a recent coherence build. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#434 @davidfowl @HaoK