Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Fix Logged elapsed time #485

Closed
wants to merge 1 commit into from
Closed

Fix Logged elapsed time #485

wants to merge 1 commit into from

Conversation

tmds
Copy link
Contributor

@tmds tmds commented Nov 17, 2015

Fixes #478

@Tratcher
Copy link
Member

@sebastienros

@JunTaoLuo
Copy link
Contributor

Verified that Environment.TickCount is always in milliseconds on Windows/Linux/Mac across clr/coreclr/mono. :shipit: from me. Note that this will mean that our logging of elapsed time will remain at the millisecond resolution. @sebastienros

@sebastienros
Copy link
Member

It's more than the millisecond, the documentation states that it's in the order of 10ms.
But :shipit:

@JunTaoLuo
Copy link
Contributor

actually why are we not using TimeSpan.FromMilliseconds?

@sebastienros
Copy link
Member

I think you are confused, or you confused me.

@JunTaoLuo
Copy link
Contributor

Actually using new Timespan(<long>) 3-10x times faster than TimeSpan.FromMilliseconds(<double>) so the current implementation is good.

@JunTaoLuo
Copy link
Contributor

Going to close and reopen to trigger the cla bot

@JunTaoLuo JunTaoLuo closed this Nov 18, 2015
@JunTaoLuo JunTaoLuo reopened this Nov 18, 2015
JunTaoLuo pushed a commit that referenced this pull request Nov 18, 2015
Convert Environment Ticks to TimeSpan Ticks
@JunTaoLuo
Copy link
Contributor

merged to dev

@benaadams
Copy link
Contributor

@JunTaoLuo added PR for sub-millisecond timings: "Higher accuracy in timings" #543

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants