This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Configure ApplicationName of ApplicationEnvironment on WebHostBuilder #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +33,8 @@ public WebHostOptions(IConfiguration configuration) | |||
|
|
|||
| public string Application { get; set; } | |||
|
|
|||
| public string EnvironmentApplication { get; set; } | |||
JunTaoLuo
force-pushed
the
johluo/configure-applicationname
branch
from
874efec to
10c41ff
Compare
| appEnv = new WrappedApplicationEnvironment(_options.ApplicationBasePath, appEnv); | ||
| } | ||
| var applicationBasePath = ResolvePath(_options.ApplicationBasePath, appEnv.ApplicationBasePath); | ||
| var environmentApplicationName = ResolveStartupAssemblyName() ?? appEnv.ApplicationName; |
There was a problem hiding this comment.
I don't think there will ever be a case where we default to appEnv.ApplicationName since we need to specify a startup assembly/type/method to build the webhost. But I guess keeping the fallback doesn't hurt.
There was a problem hiding this comment.
Yeah this would work for us. Is @davidfowl ok with this behavior?
|
🆙📅 |
|
Better. @pranavkm, is that what you were after? |
| @@ -221,12 +221,29 @@ private IServiceCollection BuildHostingServices() | |||
| return services; | |||
| } | |||
|
|
|||
| private string ResolveStartupAssemblyName() | |||
| { | |||
| if (_startup != null) | |||
|
There are some other changes I'd like to see after this change is in. |
|
Why is travis failing /cc @pranavkm |
JunTaoLuo
force-pushed
the
johluo/configure-applicationname
branch
from
52050d5 to
b52bf96
Compare
|
🆙📅 cc @Tratcher @davidfowl |
| if (_startup != null) | ||
| { | ||
| var startupAssemblyLocation = Path.GetDirectoryName(_startup.ConfigureDelegate.Target.GetType().GetTypeInfo().Assembly.Location); | ||
| if (startupAssemblyLocation != null) { |
There was a problem hiding this comment.
bad formatting 😄
_startup.ConfigureDelegate.Target.GetType().GetTypeInfo().Assembly.Location
This will be null.
There was a problem hiding this comment.
It's fine, Path.GetDirectoryName returns null if the path is null
|
|
JunTaoLuo
force-pushed
the
johluo/configure-applicationname
branch
from
dcd2035 to
b48b5f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#613
cc @Tratcher @pranavkm