This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Rename AppendEncoded() to AppendHtml()
#451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ public interface IHtmlContentBuilder : IHtmlContent | |||
| /// </summary> | |||
| /// <param name="encoded">The HTML encoded <see cref="string"/> to append.</param> | |||
| /// <returns>The <see cref="IHtmlContentBuilder"/>.</returns> | |||
| IHtmlContentBuilder AppendEncoded(string encoded); | |||
| IHtmlContentBuilder AppendHtml(string encoded); | |||
There was a problem hiding this comment.
Should the documenation and parameter name change? example: AppendHtml("<b>") ...the string is not encoded but raw html...
Same comment in all other relevant places.
There was a problem hiding this comment.
The parameter name is entirely correct and a good counterpoint to the unencoded parameter in Append(). In your example "<b>" is as encoded as it's going to get.
dougbu
force-pushed
the
dougbu/append.html.3225
branch
from
607d975 to
8ef572c
Compare
Also correct parameter names and doc comments - add `xml-docs-test` to ensure this doc comments remain valid in the future
|
@kichalla updated to fix parameter names, |
| @@ -26,9 +26,9 @@ internal class BufferedHtmlContent : IHtmlContentBuilder | |||
| /// </summary> | |||
| /// <param name="value">The <c>string</c> to be appended.</param> | |||
There was a problem hiding this comment.
xml-docs-test missed this. will fix.
|
@kichalla CI builds are failing because Coherence hasn't made recent Common changes available. This is ready to go. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppendEncoded()toAppendHtml()andSetContentEncoded()toSetHtmlContent()Mvc#3225, 1 of 3