This repository was archived by the owner on Nov 1, 2018. It is now read-only.
Upgrade to VS 2017 #322
Merged
Upgrade to VS 2017 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2017 16:25
Re-enable when dotnet/sdk#696 is resolved
| @@ -11,35 +11,51 @@ | |||
| using Microsoft.Extensions.Logging; | |||
| using Xunit; | |||
| using Xunit.Sdk; | |||
| using Xunit.Abstractions; | |||
| using Microsoft.AspNetCore.Testing; | |||
Tratcher
approved these changes
Feb 3, 2017
| @@ -11,35 +11,51 @@ | |||
| using Microsoft.Extensions.Logging; | |||
| using Xunit; | |||
| using Xunit.Sdk; | |||
|
|
||
| namespace Microsoft.AspNetCore.Testing | ||
| { | ||
| public class XunitLogger : ILogger, IDisposable |
There was a problem hiding this comment.
Yes. aspnet/Testing#243
|
Disabling is a little different from removing the Standalone project entirely. Shouldn't it still be "ported" |
|
We don't need separate standalone projects anymore. Standalone vs portable is a publish time decision, not a build decision. |
Tratcher
reviewed
Feb 3, 2017
| @@ -0,0 +1,24 @@ | |||
| # EditorConfig is awesome:http://EditorConfig.org | |||
There was a problem hiding this comment.
@muratg is this something we want in all the projects?
@natemcmaster Which editors understand this? Does it require plugins?
There was a problem hiding this comment.
Which editors understand this?
VS 2017 (no plugins).
VS Code with plugin.
It's not yet enforced by csc, but IIUC they are planning to add that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove project.json and move to MSBuild.
Had to disable standalone tests because of dotnet/sdk#696. I will open an issue to re-enable them.
Resolves #321