Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Add EventSource events #1211

Closed
kichalla opened this issue Nov 14, 2016 · 8 comments
Closed

Add EventSource events #1211

kichalla opened this issue Nov 14, 2016 · 8 comments
Assignees
@natemcmaster
Labels
3 - Done enhancement
Milestone
2.0.0-preview1

Comments

@kichalla
Copy link
Member

Events:

  • Connection Id (to establish correlation with the current request)
@kichalla
Copy link
Member Author

@davidfowl @rynowak @shirhatti

@muratg muratg added this to the 1.2.0 milestone Nov 21, 2016
@muratg
Copy link
Contributor

muratg commented Nov 21, 2016

cc @shirhatti

@muratg
Copy link
Contributor

muratg commented Nov 21, 2016

See the work done in Hosting for adding EventSource: aspnet/Hosting#883

@halter73
Copy link
Member

I think it might be possible to implement this on top of logging scopes once we do #640.

natemcmaster pushed a commit that referenced this issue Nov 22, 2016
Create KestrelEventSource
10a6720 
Adds an EventSource for Kestrel named 'Microsoft-AspNetCore-Server-Kestrel' with the following event and properties:

ConnectionStart:
 - connectionId
 - serverAddress
 - localEndPoint
 - remoteEndPoint

 Resolves #1211
natemcmaster pushed a commit that referenced this issue Nov 22, 2016
Create KestrelEventSource
47efdee 
Adds an EventSource for Kestrel named 'Microsoft-AspNetCore-Server-Kestrel' with the following event and properties:

ConnectionStart:
 - connectionId
 - serverAddress
 - localEndPoint
 - remoteEndPoint

 Resolves #1211
@natemcmaster
Copy link
Contributor

natemcmaster commented Nov 22, 2016 •
edited
Loading

Drafting a list of events we should include. Please add more if you want them

  • ConnectionStart:
    • connectionId
    • serverAddress
    • localEndPoint
    • remoteEndPoint

@muratg
Copy link
Contributor

muratg commented Nov 23, 2016

@shirhatti Could you review Nate's list?

@natemcmaster
Copy link
Contributor

For cross reference, here are the items we send to ILogger: https://github.com/aspnet/KestrelHttpServer/blob/e55c62444bdd34274173b011720c03f23c4db2f5/src/Microsoft.AspNetCore.Server.Kestrel/Internal/Infrastructure/KestrelTrace.cs

@natemcmaster
Copy link
Contributor

@glennc any input on the list of events we should include?

Ping @shirhatti as well.

@muratg muratg modified the milestones: 1.2.0, 2.0.0 Jan 12, 2017
@natemcmaster natemcmaster mentioned this issue Mar 13, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@natemcmaster natemcmaster

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
4 participants
@halter73 @muratg @natemcmaster @kichalla