This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Add IHttpConnectionFeature.ConnectionId. #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -194,18 +192,18 @@ private void OnRead(UvStreamHandle handle, int status) | |||
|
|
|||
| private Frame CreateFrame() | |||
| { | |||
| return FrameFactory(this, _remoteEndPoint, _localEndPoint, _filterContext?.PrepareRequest); | |||
| return FrameFactory(this); | |||
Tratcher
force-pushed
the
tratcher/connectionid
branch
from
1ea16f9 to
a97f6b3
Compare
|
Updated |
|
|
| public Connection(ListenerContext context, UvStreamHandle socket) : base(context) | ||
| { | ||
| _socket = socket; | ||
| ConnectionControl = this; | ||
|
|
||
| _connectionId = Interlocked.Increment(ref _lastConnectionId); | ||
| ConnectionId = Interlocked.Increment(ref _lastConnectionId).ToString(CultureInfo.InvariantCulture); |
There was a problem hiding this comment.
Not performant enough. Take a look at what we did with request id and copy it.
There was a problem hiding this comment.
As this is a property could it be lazy-init? Though might not work with the logging; as will currently always init.
Logging could be passed a ConnectionContext rather than ConnectionId and if enabled at that level then call ConnectionId which inits the value.
Task.Id in coreclr uses this approach dotnet/coreclr#3139
There was a problem hiding this comment.
Keep in mind that this is once per connection, not per request. I think Frame's copy constructor would always resolve it anyways.
Tratcher
force-pushed
the
tratcher/connectionid
branch
from
a97f6b3 to
f1e1d3a
Compare
|
Updated |
Tratcher
force-pushed
the
tratcher/connectionid
branch
from
f1e1d3a to
1495745
Compare
Tratcher
force-pushed
the
tratcher/connectionid
branch
from
1495745 to
aef612b
Compare
This was referenced Feb 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on aspnet/HttpAbstractions#564
@halter73
Most of the noise is that I changed the existing connectionId from long to string. I also cleaned up FrameFactory.