This repository has been archived by the owner on Nov 21, 2018. It is now read-only.
Add more package to package cache. #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
commented
Apr 24, 2017
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <IncludeBuildOutput>false</IncludeBuildOutput> | |||
| <TargetFramework>netstandard1.6</TargetFramework> | |||
| <TargetFramework>netcoreapp2.0</TargetFramework> | |||
There was a problem hiding this comment.
I had to bump this to netcoreapp2.0 since M.A.Diagnostics.Identity.Service targets net46/netcoreapp2.0. Any reason why this package is not targeting netstandard1.x? @javiercn
There was a problem hiding this comment.
We need Certificate Signing APIs that are only available in .NET Core 2.0
There was a problem hiding this comment.
I think this is fine, but I'd like @DamianEdwards to confirm this is ok. This means the metapackage can't be used on .NET Framework, but I think for 2.0 that's fine.
|
LGTM (The identity service part) |
Eilon
approved these changes
Apr 24, 2017
JunTaoLuo
force-pushed
the
johluo/add-more-packages
branch
from
37c8ebc to
c6fcd74
Compare
|
Clarified issues with @DamianEdwards offline in person. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #21 #39
I'm not able to add Microsoft.CodeAnalysis.Razor.Workspaces however since it has a PCL dependency: Microsoft.Composition 1.0.27
cc @Eilon @DamianEdwards