[Fixes #4317] UrlResolutionTagHelper doesn't work with TagHelpers tha…

…t run before and supress output
aspnet · Mar 30, 2016 · 2e8bb07 · 2e8bb07
1 parent e1abb47
commit 2e8bb07
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/src/Microsoft.AspNetCore.Mvc.Razor/TagHelpers/UrlResolutionTagHelper.cs b/src/Microsoft.AspNetCore.Mvc.Razor/TagHelpers/UrlResolutionTagHelper.cs
@@ -125,6 +125,11 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
                 throw new ArgumentNullException(nameof(output));
             }
 
+            if (output.TagName == null)
+            {
+                return;
+            }
+
             string[] attributeNames;
             if (ElementAttributeLookups.TryGetValue(output.TagName, out attributeNames))
             {

diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.Test/TagHelpers/UrlResolutionTagHelperTest.cs b/test/Microsoft.AspNetCore.Mvc.Razor.Test/TagHelpers/UrlResolutionTagHelperTest.cs
@@ -36,6 +36,35 @@ public static TheoryData ResolvableUrlData
             }
         }
 
+        [Fact]
+        public void Process_DoesNothingIfTagNameIsNull()
+        {
+            // Arrange
+            var tagHelperOutput = new TagHelperOutput(
+                tagName: null,
+                attributes: new TagHelperAttributeList
+                {
+                    { "href", "~/home/index.html" }
+                },
+                getChildContentAsync: (useCachedResult, encoder) => Task.FromResult<TagHelperContent>(null));
+
+            var tagHelper = new UrlResolutionTagHelper(Mock.Of<IUrlHelperFactory>(), new HtmlTestEncoder());
+            var context = new TagHelperContext(
+                allAttributes: new TagHelperAttributeList(
+                    Enumerable.Empty<TagHelperAttribute>()),
+                items: new Dictionary<object, object>(),
+                uniqueId: "test");
+
+            // Act
+            tagHelper.Process(context, tagHelperOutput);
+
+            // Assert
+            var attribute = Assert.Single(tagHelperOutput.Attributes);
+            Assert.Equal("href", attribute.Name, StringComparer.Ordinal);
+            var attributeValue = Assert.IsType<string>(attribute.Value);
+            Assert.Equal("~/home/index.html", attributeValue, StringComparer.Ordinal);
+        }
+
         [Theory]
         [MemberData(nameof(ResolvableUrlData))]
         public void Process_ResolvesTildeSlashValues(string url, string expectedHref)