React to StringSegment changes

aspnet · May 23, 2017 · 53c56f5 · 53c56f5
1 parent 3c7a2dc
commit 53c56f5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/Microsoft.AspNetCore.Mvc.Core/Formatters/TextOutputFormatter.cs b/src/Microsoft.AspNetCore.Mvc.Core/Formatters/TextOutputFormatter.cs
@@ -185,7 +185,7 @@ private Encoding MatchAcceptCharacterEncoding(IList<StringWithQualityHeaderValue
                 for (var i = 0; i < acceptValues.Count; i++)
                 {
                     var charset = acceptValues[i].Value;
-                    if (!string.IsNullOrEmpty(charset))
+                    if (!StringSegment.IsNullOrEmpty(charset))
                     {
                         for (var j = 0; j < SupportedEncodings.Count; j++)
                         {

diff --git a/test/Microsoft.AspNetCore.Mvc.Formatters.Json.Test/JsonOutputFormatterTests.cs b/test/Microsoft.AspNetCore.Mvc.Formatters.Json.Test/JsonOutputFormatterTests.cs
@@ -477,7 +477,7 @@ private static ActionContext GetActionContext(
             var headers = new HeaderDictionary();
             request.Setup(r => r.ContentType).Returns(contentType.ToString());
             request.SetupGet(r => r.Headers).Returns(headers);
-            headers[HeaderNames.AcceptCharset] = contentType.Charset;
+            headers[HeaderNames.AcceptCharset] = contentType.Charset.ToString();
             var response = new Mock<HttpResponse>();
             response.SetupGet(f => f.Body).Returns(responseStream ?? new MemoryStream());
             var httpContext = new Mock<HttpContext>();

diff --git a/...rosoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs b/...rosoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs
@@ -645,7 +645,7 @@ private static HttpContext GetHttpContext(string contentType)
             var request = new Mock<HttpRequest>();
 
             var headers = new HeaderDictionary();
-            headers["Accept-Charset"] = MediaTypeHeaderValue.Parse(contentType).Charset;
+            headers["Accept-Charset"] = MediaTypeHeaderValue.Parse(contentType).Charset.ToString();
             request.Setup(r => r.ContentType).Returns(contentType);
             request.SetupGet(r => r.Headers).Returns(headers);
 

diff --git a/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlSerializerOutputFormatterTest.cs b/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlSerializerOutputFormatterTest.cs
@@ -406,7 +406,7 @@ private static HttpContext GetHttpContext(string contentType)
             var request = new Mock<HttpRequest>();
 
             var headers = new HeaderDictionary();
-            headers["Accept-Charset"] = MediaTypeHeaderValue.Parse(contentType).Charset;
+            headers["Accept-Charset"] = MediaTypeHeaderValue.Parse(contentType).Charset.ToString();
             request.Setup(r => r.ContentType).Returns(contentType);
             request.SetupGet(r => r.Headers).Returns(headers);
 

diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/TempDataInCookiesTest.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/TempDataInCookiesTest.cs
@@ -53,9 +53,9 @@ public async Task RoundTripLargeData_WorksWithChunkingCookies(int size)
                 .Select(setCookieValue => SetCookieHeaderValue.Parse(setCookieValue));
             foreach (var cookieTempDataProviderCookie in cookieTempDataProviderCookies)
             {
-                Assert.NotNull(cookieTempDataProviderCookie.Value);
+                Assert.NotNull(cookieTempDataProviderCookie.Value.Value);
                 Assert.Equal("/", cookieTempDataProviderCookie.Path);
-                Assert.Null(cookieTempDataProviderCookie.Domain);
+                Assert.Null(cookieTempDataProviderCookie.Domain.Value);
                 Assert.False(cookieTempDataProviderCookie.Secure);
             }
 
@@ -73,7 +73,7 @@ public async Task RoundTripLargeData_WorksWithChunkingCookies(int size)
             Assert.NotNull(setCookieHeaderValue);
             Assert.Equal(string.Empty, setCookieHeaderValue.Value);
             Assert.Equal("/", setCookieHeaderValue.Path);
-            Assert.Null(setCookieHeaderValue.Domain);
+            Assert.Null(setCookieHeaderValue.Domain.Value);
             Assert.NotNull(setCookieHeaderValue.Expires);
             Assert.True(setCookieHeaderValue.Expires < DateTimeOffset.Now); // expired cookie
 
@@ -105,7 +105,7 @@ public async Task Redirect_RetainsTempData_EvenIfAccessed_AndSetsAppropriateCook
                 .FirstOrDefault(setCookieHeaderValue => setCookieHeaderValue.Name == CookieTempDataProvider.CookieName);
             Assert.NotNull(setCookieHeader);
             Assert.Equal("/", setCookieHeader.Path);
-            Assert.Null(setCookieHeader.Domain);
+            Assert.Null(setCookieHeader.Domain.Value);
             Assert.False(setCookieHeader.Secure);
             Assert.Null(setCookieHeader.Expires);
 
@@ -129,7 +129,7 @@ public async Task Redirect_RetainsTempData_EvenIfAccessed_AndSetsAppropriateCook
             Assert.NotNull(setCookieHeader);
             Assert.Equal(string.Empty, setCookieHeader.Value);
             Assert.Equal("/", setCookieHeader.Path);
-            Assert.Null(setCookieHeader.Domain);
+            Assert.Null(setCookieHeader.Domain.Value);
             Assert.NotNull(setCookieHeader.Expires);
             Assert.True(setCookieHeader.Expires < DateTimeOffset.Now); // expired cookie
         }
@@ -158,7 +158,7 @@ public async Task CookieTempDataProviderCookie_SetsSecureAttributeOnCookie_OnlyI
                 .FirstOrDefault(setCookieHeaderValue => setCookieHeaderValue.Name == CookieTempDataProvider.CookieName);
             Assert.NotNull(setCookieHeader);
             Assert.Equal("/", setCookieHeader.Path);
-            Assert.Null(setCookieHeader.Domain);
+            Assert.Null(setCookieHeader.Domain.Value);
             Assert.Equal(secureRequest, setCookieHeader.Secure);
             Assert.Null(setCookieHeader.Expires);
         }