Mock HttpContext, not DefaultHttpContext

- build break - recent HttpAbstractions changes made `DefaultHttpContext` harder to mock (would need `CallBase=true`)
aspnet · Jan 3, 2016 · 568b061 · 568b061
1 parent ba5fe60
commit 568b061
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 18 deletions.
diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/ControllerBaseTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/ControllerBaseTest.cs
@@ -448,7 +448,7 @@ public void Created_WithRelativeUriParameter_SetsCreatedLocation()
         public void Created_IDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
             var uri = new Uri("/test/url", UriKind.Relative);
 
@@ -534,7 +534,7 @@ public void CreatedAtAction_WithActionControllerRouteValues_SetsSameValues()
         public void CreatedAtAction_IDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -616,7 +616,7 @@ public void CreatedAtRoute_WithParameterRouteNameAndValues_SetsResultSamePropert
         public void CreatedAtRoute_IDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -709,7 +709,7 @@ public void File_WithPathAndFileDownloadName()
         public void File_WithStream()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -731,7 +731,7 @@ public void File_WithStream()
         public void File_WithStreamAndFileDownloadName()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -799,7 +799,7 @@ public void HttpNotFound_SetsStatusCodeAndResponseContent()
         public void HttpNotFound_IDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -837,7 +837,7 @@ public void Ok_SetsStatusCode()
         public void Ok_WithIDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -891,7 +891,7 @@ public void BadRequest_SetsStatusCodeAndValue_Object()
         public void BadRequest_IDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();

diff --git a/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/ControllerTest.cs b/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/ControllerTest.cs
@@ -3,20 +3,15 @@
 
 using System;
 using System.Collections.Generic;
-using System.IO;
 using System.Linq;
 using System.Reflection;
-using System.Text;
 using System.Threading.Tasks;
 using Microsoft.AspNet.Http;
 using Microsoft.AspNet.Http.Internal;
 using Microsoft.AspNet.Mvc.Filters;
 using Microsoft.AspNet.Mvc.ModelBinding;
 using Microsoft.AspNet.Mvc.ModelBinding.Validation;
 using Microsoft.AspNet.Mvc.ViewFeatures;
-using Microsoft.AspNet.Routing;
-using Microsoft.AspNet.Testing;
-using Microsoft.Net.Http.Headers;
 using Moq;
 using Newtonsoft.Json;
 using Xunit;
@@ -189,7 +184,7 @@ public void Controller_Json_WithParameterValue_SetsRespectiveProperty()
         public void Controller_Json_IDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -212,7 +207,7 @@ public void Controller_Json_IDisposableObject_RegistersForDispose()
         public void Controller_JsonWithParameterValueAndSerializerSettings_IDisposableObject_RegistersForDispose()
         {
             // Arrange
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestableController();
@@ -262,7 +257,7 @@ public void ControllerDispose_CallsDispose()
             // Assert
             Assert.True(controller.DisposeCalled);
         }
-        
+
         [Fact]
         public void TempData_CanSetAndGetValues()
         {

diff --git a/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/ControllerUnitTestabilityTests.cs b/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/ControllerUnitTestabilityTests.cs
@@ -149,7 +149,7 @@ public void ControllerFileStream_InvokedInUnitTests()
             var content = "<html>CreatedBody</html>";
             var contentType = "text/html";
             var fileName = "Created.html";
-            var mockHttpContext = new Mock<DefaultHttpContext>();
+            var mockHttpContext = new Mock<HttpContext>();
             mockHttpContext.Setup(x => x.Response.RegisterForDispose(It.IsAny<IDisposable>()));
 
             var controller = new TestabilityController();
@@ -563,7 +563,7 @@ public void ViewComponent_WithName()
 
             // Assert
             Assert.NotNull(result);
-            
+
             Assert.Equal("TagCloud", result.ViewComponentName);
         }