[Fixes #3230] Remove use of reflection in MutableObjectModelBinder

aspnet · Jan 12, 2016 · 6ba05ad · 6ba05ad
1 parent 1ca25c4
commit 6ba05ad
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/src/Microsoft.AspNet.Mvc.Core/ModelBinding/MutableObjectModelBinder.cs b/src/Microsoft.AspNet.Mvc.Core/ModelBinding/MutableObjectModelBinder.cs
@@ -484,25 +484,17 @@ protected virtual void SetProperty(
                 throw new ArgumentNullException(nameof(propertyMetadata));
             }
 
-            var bindingFlags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.IgnoreCase;
-            var property = bindingContext.ModelType.GetProperty(propertyMetadata.PropertyName, bindingFlags);
-
-            if (property == null)
-            {
-                // Nothing to do if property does not exist.
-                return;
-            }
 
             if (!result.IsModelSet)
             {
                 // If we don't have a value, don't set it on the model and trounce a pre-initialized value.
                 return;
             }
 
-            if (!property.CanWrite)
+            if (propertyMetadata.IsReadOnly)
             {
                 // Try to handle as a collection if property exists but is not settable.
-                AddToProperty(bindingContext, metadata, property, result);
+                AddToProperty(bindingContext, metadata, propertyMetadata, result);
                 return;
             }
 
@@ -520,11 +512,9 @@ protected virtual void SetProperty(
         private void AddToProperty(
             ModelBindingContext bindingContext,
             ModelMetadata modelMetadata,
-            PropertyInfo property,
+            ModelMetadata propertyMetadata,
             ModelBindingResult result)
         {
-            var propertyMetadata = modelMetadata.Properties[property.Name];
-
             var target = propertyMetadata.PropertyGetter(bindingContext.Model);
             var source = result.Model;
             if (target == null || source == null)