-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove use of RequiredValidator from Mutable Model Binder #2526
Comments
Had three cases when we opened this bug:
In all cases, we previously provided a fallback error message. However case 1 no longer exists because the fallback code existed only in model binding. @rynowak removed the We have a number of other bugs and design change requests out related to cases 2 and 3. For now i.e. for this bug, I will just remove the fallback message from case 2. If there is no tl;dr; wherever I said " |
Postponing based on offline conversations. Will discuss and decide what to do about the mentioned cluster of bugs touching on how |
To be clear, in the Mutable Model Binder where it does some fancy stuff to create an error message for a "not provided" value on the wire, just put in our own custom error message always. In the far future, we can look at some way to customize this. |
The error message should be: Copied from #2493 |
The future work is captured in #2303. |
…indRequired]` - only use MVC error message when `[BindRequired]` is violated - update that error message to more clearly describe the problem - enable all tests skipped due to dupe bug #2493 - update expectations of a few tests using the old messages nits: - rename `ModelBinding_MissingRequiredMember` to `ModelBinding_MissingBindRequiredMember` - remove `<param>` description of removed `requiredValidator` parameter - remove unused `MutableObjectModelBinderTest.GetRequiredValidator()`
We should just ignore this case and let whatever happens, happen.
The text was updated successfully, but these errors were encountered: