asp-append-version not working on Linux

[Daniel15]

In my _Layout.cshtml:

<link rel="stylesheet" href="~/cache/main.min.css" asp-append-version="true"/>

On my development machine (Windows 7, Visual Studio 2015, Kestrel), this correctly appends the version:

<link rel="stylesheet" href="/cache/main.min.css?v=GQLFOo4-np2RJQauQG_3iKMNbSjDM5osk_tVLhNAnhE" />

However, in my production environment (Mono 4.0.2, Kestrel), no version is appended:

<link rel="stylesheet" href="/cache/main.min.css" />

Tested on Mono 4.0.2 and ASP.NET 5 Beta 6.

I'm deploying the site by doing dnu publish into a temporary directory, then rsyncing that temporary directory to the remote server.

[Daniel15]

The problematic section of code is this part in FileVersionProvider.cs:

            Uri uri;
            if (Uri.TryCreate(resolvedPath, UriKind.Absolute, out uri))
            {
                // Don't append version if the path is absolute.
                return path;
            }

Mono's implementation of Uri.TryCreate is resolving /foo.css to file:///foo.css, because technically /foo.css is an absolute path to a file on Linux. Thus, it's just returning path unmodified. 😭

I think it should either explicitly be checking IsFile on the Uri. I'll submit a patch.

[danroth27]

@NTaylorMullen @ajaybhargavb

Yup, looks like something we would love to get a PR for. Thanks for finding the issue!

[Daniel15]

I already submitted pull request #2980 to fix this issue :)

Sent from my phone
On Aug 18, 2015 1:07 PM, "Daniel Roth" [email protected] wrote:

@NTaylorMullen https://github.com/NTaylorMullen @ajaybhargavb
https://github.com/ajaybhargavb

Yup, looks like something we would love to get a PR for. Thanks for
finding the issue!

—
Reply to this email directly or view it on GitHub
#2979 (comment).

[dougbu]

a2e53e8