Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

DefaultModelMetadata.PropertyGetter is not null-safe #2986

Closed
dougbu opened this issue Aug 17, 2015 · 1 comment
Closed

DefaultModelMetadata.PropertyGetter is not null-safe #2986

dougbu opened this issue Aug 17, 2015 · 1 comment
Assignees
@rynowak
Labels
3 - Done bug
Milestone
1.0.0-beta8

Comments

@dougbu
Copy link
Member

dougbu commented Aug 17, 2015

No current MVC code uses DefaultModelMetadata.PropertyGetter. If it were used, would find null values e.g. ModelMetadata.PropertyGetter(null) lead to NREs. Root cause may be the fact PropertyHelper.MakeNullSafeFastPropertyGetter() is not referenced.

Experienced this issue while developing PR #2984.
@dougbu dougbu mentioned this issue Aug 17, 2015
Closed
@danroth27 danroth27 added this to the 6.0.0-beta8 milestone Aug 18, 2015
rynowak added a commit that referenced this issue Aug 19, 2015
@rynowak
Fix #2986 - Make ModelMetadata getters null-safe
91147d4
@rynowak
Copy link
Member

rynowak commented Aug 21, 2015

b5c9d90

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
3 participants
@rynowak @danroth27 @dougbu