Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Specifying @model in a page ignores value specified by @inherit from a _ViewImport #3144

Closed
pranavkm opened this issue Sep 16, 2015 · 1 comment
Closed

Specifying @model in a page ignores value specified by @inherit from a _ViewImport #3144

pranavkm opened this issue Sep 16, 2015 · 1 comment
Assignees
@pranavkm
Labels
3 - Done bug
Milestone
1.0.0-beta8

Comments

@pranavkm
Copy link
Contributor

We have code that prevents @model and @inherits from being specified in the same page. However this check happens at parse time. Consequently specifying an @inherits MyBase<TModel> in _ViewImports and @model CustomModel doesn't produce an error. Instead, the @model wins and resets the base type to the default (RazorPage<>).

This seems like a reasonable thing to do - we shouldn't error on it.

Related: #3143
@pranavkm pranavkm added the bug label Sep 16, 2015
@pranavkm pranavkm mentioned this issue Sep 16, 2015
Closed
@danroth27 danroth27 added this to the 6.0.0-beta8 milestone Sep 16, 2015
@danroth27
Copy link
Member

Please chat with @Eilon on the approach for this issue.

@ajaybhargavb ajaybhargavb mentioned this issue Sep 22, 2015
Closed
pranavkm added a commit that referenced this issue Sep 23, 2015
@pranavkm
Allow @model specified in a page work with @inherits directive in
cac626d 
_ViewImports

Fixes #3144
@pranavkm pranavkm mentioned this issue Sep 23, 2015
Closed
pranavkm added a commit that referenced this issue Sep 23, 2015
@pranavkm
Allow @model specified in a page work with @inherits directive in
6075749 
_ViewImports

Fixes #3144
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
2 participants
@pranavkm @danroth27