Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Add LocalRedirectResult class and helper method #3346

Closed
Eilon opened this issue Oct 19, 2015 · 3 comments
Closed

Add LocalRedirectResult class and helper method #3346

Eilon opened this issue Oct 19, 2015 · 3 comments
Assignees
@ajaybhargavb
Labels
3 - Done enhancement
Milestone
1.0.0-rc1

Comments

@Eilon
Copy link
Member

Eilon commented Oct 19, 2015

Add a new LocalRedirectResult class that does a redirect if Url.IsLocalUrl returns true, and throws otherwise.

Also need to add a LocalRedirect factory method on the Controller base class.
@Eilon Eilon mentioned this issue Oct 19, 2015
Closed
@Eilon
Copy link
Member Author

Eilon commented Oct 19, 2015

The doc comments for the factory method and type need to mention that it helps to protect against open redirects.

@blowdart FYI

@danroth27 danroth27 added this to the 6.0.0-rc1 milestone Oct 20, 2015
@danroth27
Copy link
Member

@rustd Do we need this for RC1?

@rustd
Copy link

rustd commented Oct 20, 2015

If we can. It will help clean up the template.

@ajaybhargavb ajaybhargavb mentioned this issue Oct 21, 2015
Merged
ajaybhargavb added a commit that referenced this issue Oct 22, 2015
@ajaybhargavb
Added LocalRedirectresult
cfa666f 
- Fixes #3346
- Added helper method in controller
- Added relevant tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-rc1
Development

No branches or pull requests
4 participants
@Eilon @rustd @ajaybhargavb @danroth27