Limit [FromServices] to apply only to parameters

[Eilon]

This should help reduce a lot of the confusion around this feature.

It currently applies to parameters and properties. The problem with properties is that it appears to many people that it can be applied to any property of any object. But in reality it works only with properties on objects that are model bound, which is controller properties, and sub-properties of types used in MVC action method parameters.

By limiting [FromServices] to only parameters, that will restrict the usage to one that will always work: top-level action method parameters.

cc @rynowak

[rynowak]

The problem with properties is that it appears to many people that it can be applied to any property of any object.

Agreed, we've had a number of issues posted by users with confusion around how this feature should be used. There's really been a fairly large amount of feedback both of the kinds "[FromServices] is weird and I don't like it" and "[FromServices] has confounded me". It feels like a trap, and something that the team would still be answering questions about years from now.

We feel like most valuable scenario for [FromServices] is on method parameter to an action for a service that you only need in that one place.

/cc @danroth27 - docs changes

To anyone in love with the current [FromServices], I'd strongly recommend looking into a DI system that can do property injection (Autofac, for example).

[Eilon]

@pranavkm please sync with @rynowak on what kind of sample we might want for this to show the current behavior.

[Eilon]

@pranavkm Done?

[Bartmax]

👍