Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Improve usability of HtmlLocalizer #3716

Closed
4 tasks done
DamianEdwards opened this issue Dec 10, 2015 · 0 comments
Closed
4 tasks done

Improve usability of HtmlLocalizer #3716

DamianEdwards opened this issue Dec 10, 2015 · 0 comments
Assignees
@DamianEdwards
Labels
3 - Done enhancement feature-Localization
Milestone
1.0.0-rc2

Comments

@DamianEdwards
Copy link
Member

  • Make IHtmlLocalizer indexers return LocalizedHtmlString
  • Make IHtmlLocalizer not inherit from IStringLocalizer
  • Add IHtmlLocalizer.GetString methods that are equivalent to IStringLocalizer.GetString
  • Rename IHtmlLocalizer.Html methods to IHtmlLocalizer.GetHtml
@DamianEdwards DamianEdwards changed the title Make LocalizedHtmlString derive from LocalizedString and implement IHtmlContent Improve usability of HtmlLocalizer Dec 10, 2015
@DamianEdwards DamianEdwards mentioned this issue Dec 10, 2015
Closed
@Eilon Eilon added this to the 6.0.0-rc2 milestone Dec 10, 2015
@DamianEdwards DamianEdwards self-assigned this Dec 11, 2015
DamianEdwards added a commit that referenced this issue Dec 17, 2015
@DamianEdwards
Improve usability of IHtmlLocalizer & associated API:
b2dc808 
- IHtmlLocalizer no longer derives from IStringLocalizer
- IHtmlLocalizer indexer now returns LocalizedHtmlString
- IHtmlLocalizer has GetString methods now that act the same as IStringLocalizer.GetString
- Made LocalizedHtmlString a struct to match LocalizedString
- Updated samples in response to aspnet/Localization#167
- Fixes some doc comments
- Fixed tests
- #3716
@DamianEdwards DamianEdwards mentioned this issue Dec 17, 2015
Merged
DamianEdwards added a commit that referenced this issue Dec 18, 2015
@DamianEdwards
Improve usability of IHtmlLocalizer & associated API:
0c3e7b5 
- IHtmlLocalizer no longer derives from IStringLocalizer
- IHtmlLocalizer indexer now returns LocalizedHtmlString
- IHtmlLocalizer has GetString methods now that act the same as IStringLocalizer.GetString
- Made LocalizedHtmlString a struct to match LocalizedString
- Updated samples in response to aspnet/Localization#167
- Rename "ancestor" to "parent" for loc API
- Fixes some doc comments
- Fixed tests
- #3716
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DamianEdwards DamianEdwards

Labels
3 - Done enhancement feature-Localization
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
2 participants
@Eilon @DamianEdwards