Performance Scenario: Basic Views

[rynowak]

This is top-level performance scenario for 1.0.0. We're using this item to track the status and all of the individual improvements.

Code here: https://github.com/aspnet/Performance/tree/dev/testapp/BasicViews

Summary

This is a simple browser-based app that accepts a form post, updates a database, and renders validation errors + the same form. This should be naively written, and very similar to a 'Create' view that a developer would generate using scaffolding.

• Conventional routing
• Database (localdb)
• Layout page from project template (script/link taghelpers)
• Startup code from no-auth project template
• View code using taghelpers for form and inputs

Variations

• Using TagHelpers (primary) - http://+:5000/
• Using HTML helpers - http://+:5000/Home/HtmlHelpers

Status

Scenario Status: Complete

• Update Layout Page
• Add database
• Add validation attributes
• Switch default to use taghelpers
• Add antiforgery validation + client

Known Investigations/Improvements:

• https://github.com/dotnet/cli/issues/1736 CompilationOptions memory usage
• Creating TagHelpers is surprisingly expensive #3924 TagHelper activation too expensive
• RazorPage activation is too expensive #4244 RazorPage activation too expensive
• Optimize CoerceResultToTaskAsync #4267 Optimize CoerceResultToTaskAsync
• Reduce allocations in Link/Script TagHelper #4468 Reduce allocations in Link/Script TagHelper

[rynowak]

Some baselines now that we've completed the scenario. All measurements are x64 CoreCLR.

Allocations - 3001 requests

Managed Memory Usage - After Warmup - 14.7mb

Sampling Data (execution profiling) - Here's a markdown table for top-down data

System	Percentage (Inclusive)	Stack
Routing	0.50%	Microsoft.AspNetCore.Routing.RouteCollection.RouteAsync(RouteContext)
Antiforgery Validation	4.50%	Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ValidateAntiforgeryTokenAuthorizationFilter.OnAuthorizationAsync(AuthorizationFilterContext)
ModelBinding	2.50%	Microsoft.AspNetCore.Mvc.Internal.ControllerArgumentBinder.BindActionArgumentsAsync(ControllerContext, Object)
Validation	0%	Microsoft.AspNetCore.Mvc.Internal.DefaultObjectValidator.Validate(ActionContext, IModelValidatorProvider, ValidationStateDictionary, String, Object)
EF SetEntityState	16%	Microsoft.EntityFrameworkCore.DbContext.SetEntityState(TEntity, EntityState)
EF SaveChangesAsync	5%	Microsoft.EntityFrameworkCore.DbContext.SaveChangesAsync(CancellationToken)
EF ???	16%	Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor+d__1.MoveNext()
EF Commit	18%	Microsoft.EntityFrameworkCore.Storage.RelationalTransaction.Commit()
View Rendering	30%	Microsoft.AspNetCore.Mvc.Internal.FilterActionInvoker.InvokeAllResultFiltersAsync(IActionResult)
Other	7.50%

[Eilon]

Moving to 1.0.0.

[rynowak]

Updates here - allocation data

[rynowak]

Update 5/23

Allocation Data: 3000 requests

No really significant changes here, we've made some small improvements in URL generation in routing and some improvements to generated TagHelper view code, but nothing major to report.

Sampling data is hard to summarize here - very little request time is spent doing ASP.NET related concerns, significant amount of time spent in EF. Based on this data we're still concerned about #3924 see here