Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompilationOptions is holding on a bunch of JObject objects #5314

Closed
rynowak opened this issue Mar 7, 2016 · 1 comment
Closed

CompilationOptions is holding on a bunch of JObject objects #5314

rynowak opened this issue Mar 7, 2016 · 1 comment
Assignees
@pakrym

Comments

@rynowak
Copy link
Member

rynowak commented Mar 7, 2016

Steps to reproduce

Create an MVC site and run some requests (https://github.com/aspnet/Performance/tree/dev/testapp/BasicViews used for this). See aspnet/Mvc#4175

Expected behavior

CompilationOptions doesn't hold on to a bunch of JObject objects 😆

Actual behavior

The defines argument passed here is a lazy IEnumerable<string> holding on to a bunch of parsed JSON data.

For this tiny MVC site, it's about 1.5mb per CompilationOptions instance of extra memory retained (we have 2 copies for some reason) of 14.7mb total.

image

Environment data

dotnet --version output:

.NET Command Line Tools (1.0.0-beta-001634)

Product Information:
 Version:     1.0.0-beta-001634
 Commit Sha:  3ed9361763

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.10586
 OS Platform: Windows
 Runtime Id:  win10-x64

Using "Microsoft.Extensions.DependencyModel": "1.0.0-beta-001584",
@pakrym pakrym self-assigned this Apr 4, 2016
@pakrym
Copy link
Contributor

pakrym commented May 16, 2016

Fixed: dotnet/cli#2264

@pakrym pakrym closed this as completed May 16, 2016
wli3 referenced this issue in wli3/cli Nov 14, 2018
@johnbeisner
The 'PushToBlobFeed' call cannot find the NuPkgs (#1736)
1218d9d 
* "TargetFramework" is not needed; moreover it changes the property: "OutputPath" [see: PushToBlobFeed.targets]

* Put back "TargetFramework" for the 'restore' call.
The 'PushToBlobFeed' call cannot find the NuPkg because "OutputPath" is changed.
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pakrym pakrym

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rynowak @pakrym