Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Re-instate tests on Mono #4238

Closed
ryanbrandenburg opened this issue Mar 7, 2016 · 5 comments
Closed

Re-instate tests on Mono #4238

ryanbrandenburg opened this issue Mar 7, 2016 · 5 comments
Assignees
@ryanbrandenburg
Labels
task
Milestone
1.0.0

Comments

@ryanbrandenburg
Copy link
Contributor

In #4234 we disabled some tests on mono due to dotnet/cli#1613. Once that is resolved we should re-instate these tests.
This was referenced Mar 7, 2016
Merged
Closed
@danroth27 danroth27 added the task label Mar 7, 2016
@danroth27 danroth27 added this to the 1.0.0-rc2 milestone Mar 7, 2016
@Eilon Eilon modified the milestones: 1.0.0-rc2, 1.0.0 Mar 13, 2016
rynowak added a commit that referenced this issue Mar 30, 2016
@rynowak
Fix #4238 IFormFile model binder suppresses validation
da1576a 
This change no longer suppresses validation for IFormFile and
IFormFileCollection model values. This will allow the use of [Required] on an
IFormFile model, or a custom attribute for validating IFormFileCollection.

These types already have ValidateChildren = false, so we don't recurse
into them.
@dougbu
Copy link
Member

dougbu commented May 1, 2016

Reopening because @rynowak's commit did not relate.

@dougbu dougbu reopened this May 1, 2016
@ryanbrandenburg
Copy link
Contributor Author

Isn't the task for this now to remove Mono specific things from the code?

@dougbu
Copy link
Member

dougbu commented Jun 13, 2016

@ryanbrandenburg what labels should this issue have i.e. is it "done" again? I know @rynowak's commit was unrelated but am not sure whether this and #4153 were dupes.

@ryanbrandenburg
Copy link
Contributor Author

#4153 led to this, so they are not dupes. I seem to remember @Eilon telling me to just close this, though I don't remember exactly why (a lesson to me to always give a reason when closing out an issue).

@Eilon do you remember why that was?

@Eilon
Copy link
Member

Eilon commented Jun 14, 2016

This is a bug about some mono test. Why does it matter?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanbrandenburg ryanbrandenburg

Labels
task
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
4 participants
@Eilon @danroth27 @dougbu @ryanbrandenburg