Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Move AuthorizeFilter and CORS filters into a user friendly namespace #4310

Closed
danroth27 opened this issue Mar 17, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@danroth27
Copy link
Member

Looks like the some of our built-in filters that are tied to external attributes live in an internal namespace:

https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/Internal/AuthorizeFilter.cs
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Cors/Internal/CorsAuthorizationFilter.cs

Most of the time you don't interact with these filters directly unless you are configuring them as a global filter. These filters should live in a user friendly namespace.

@Eilon
Copy link
Member

Eilon commented Mar 18, 2016

@rynowak any idea if we hid them on purpose? Presumably when adding global filters we want these types to be publicly available, no?

@rynowak
Copy link
Member

rynowak commented Mar 18, 2016

This was just over-aggressive cleanup. This should move back to a public namespace.

@Eilon Eilon added this to the 1.0.0-rc2 milestone Mar 18, 2016
@Eilon Eilon changed the title Move AuthorizeFitler and CORS filters into a user friendly namespace Move AuthorizeFilter and CORS filters into a user friendly namespace Mar 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants