Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Remove DefaultAssemblyPartDiscoveryProvider.GetAssemblyName #4366

Closed
pranavkm opened this issue Mar 29, 2016 · 2 comments
Closed

Remove DefaultAssemblyPartDiscoveryProvider.GetAssemblyName #4366

pranavkm opened this issue Mar 29, 2016 · 2 comments
Assignees
@pranavkm
Labels
3 - Done bug
Milestone
1.0.0

Comments

@pranavkm
Copy link
Contributor

We have a copy of the GetAssemblyName method from the CLI because it is currently static. This can be removed once once dotnet/cli#2117 lands.
@Eilon Eilon added this to the 1.0.0-rc2 milestone Mar 30, 2016
@Eilon
Copy link
Member

Eilon commented Mar 30, 2016

dotnet/cli#2117 is merged so hopefully we can get this into RC2 soon.

@Eilon Eilon modified the milestones: 1.0.0, 1.0.0-rc2 Apr 1, 2016
@pranavkm pranavkm changed the title Remove DefaultAssemblyTypeProvider.GetAssemblyName Remove DefaultAssemblyPartDiscoveryProvider.GetAssemblyName Apr 3, 2016
pranavkm added a commit that referenced this issue Apr 3, 2016
@pranavkm
Remove DefaultAssemblyPartDiscoveryProvider.GetAssemblyName
701869f 
Fixes #4366
@pranavkm pranavkm mentioned this issue Apr 3, 2016
Merged
@dougbu
Copy link
Member

dougbu commented Jun 13, 2016

@pranavkm was this done?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@pranavkm @Eilon @dougbu