Logging ArgumentOutOfRangeException

[smbecker]

I am not sure if this should go here or in aspnet/Logging but this log message causes a ArgumentOutOfRangeException when you attempt to enumerate over the values. Looks like another case of aspnet/Logging@410 where the LoggingMessage definition is using Define when it should be using Define().

[BrennanConroy]

@Eilon @muratg
The define needs to be fixed

[BrennanConroy]

Found another one in MVC

Mvc/src/Microsoft.AspNetCore.Mvc.Formatters.Json/Internal/MvcJsonLoggerExtensions.cs

Line 20 in a78f77a

"JSON input formatter threw an exception.");

[muratg]

@BrennanConroy Can we check what else is impacted?

@Eilon RC2?

[BrennanConroy]

Did a quick scour of our repos and couldn't find anymore cases of this.

[Eilon]

@kichalla this is for RC2, thanks!

[kichalla]

Vow. This pattern seems error prone and is only caught when logging is enabled. I think we should validate the format when the define method is called. From what I have found, seems like there is some validation that we can do. Will send out a PR for this.

[BrennanConroy]

aspnet/Logging#413

[kichalla]

Ah thanks!

[Eilon]

Done?

[muratg]

Yep, this was done. @kichalla Updated the bug tag for you :)

[kichalla]

Thanks :-)