Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Improve the log message when we a route matches but cannot find an controller/action. #4608

Closed
kichalla opened this issue May 10, 2016 · 8 comments
Assignees
Labels
3 - Done bug up-for-grabs Members of our awesome commnity can handle this issue

Comments

@kichalla
Copy link
Member

Following is how the log looks like...

image

Suggestion: We can clearly mention what action we were looking for and in which controller. Note that I enabled debug logging and probably being very descriptive is not bad.

Example: No action with name 'Foo' found on controller 'Namespace.Home''

@Eilon
Copy link
Member

Eilon commented May 10, 2016

@rynowak does this information even exist such that we can log it? We surely know the controller and action tokens but could we reliably say what controller type/namespace it was?

@javiercn
Copy link
Member

I don't think you can do this in a general/accurate way. There are many cases in which the action might be there but not match due to an httpmethod constraint, an area constraint or any other constraint that the user has assigned to the route (for which you definitely not have text for)

@rynowak
Copy link
Member

rynowak commented May 10, 2016

does this information even exist such that we can log it?

We can log the route values - that should be good enough

There are many cases in which the action might be there but not match due to an httpmethod constraint

This isn't that case. We give better logging output already for that case

@Eilon Eilon added bug 1 - Ready up-for-grabs Members of our awesome commnity can handle this issue labels May 10, 2016
@Eilon Eilon modified the milestones: 1.0.0, Backlog May 10, 2016
@khellang
Copy link
Contributor

Should this rely on RouteValueDictionary's ToString?

@felipepessoto
Copy link

I plan to work on it

@programatt
Copy link

Is there a reason why this wasn't closed? It looks like it was fixed with the PR that @juunas11 had merged in.

@Eilon Eilon modified the milestones: 2.0.0, Backlog Feb 1, 2017
@Eilon
Copy link
Member

Eilon commented Feb 1, 2017

@programatt I believe you are correct.

@kichalla can you confirm?

@kichalla
Copy link
Member Author

d44c9ae

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 - Done bug up-for-grabs Members of our awesome commnity can handle this issue
Projects
None yet
Development

No branches or pull requests

7 participants