Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Improve error message when route is matched but action is not found #5599

Closed
wants to merge 2 commits into from

Conversation

juunas11
Copy link
Contributor

@juunas11 juunas11 commented Dec 6, 2016

Route values are now logged to help with debugging

  • The logging extension now accepts the value dictionary as a parameter
  • Converted the extension to use a static action like the others
  • Unit test updated to reflect the change

Addresses #4608

@dnfclas
Copy link

dnfclas commented Dec 6, 2016

Hi @juunas11, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@kichalla
Copy link
Member

kichalla commented Jan 7, 2017

Looks good to me. cc @rynowak

Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit: @kichalla can you merge?

@kichalla
Copy link
Member

Merged with d44c9ae. Thanks! @juunas11

@kichalla kichalla closed this Jan 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants