Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Modify ICompilationLibrariesProvider to return a sequence of reference path strings #4738

Closed
pranavkm opened this issue May 25, 2016 · 0 comments
Closed

Modify ICompilationLibrariesProvider to return a sequence of reference path strings #4738

pranavkm opened this issue May 25, 2016 · 0 comments
Assignees
@pranavkm
Labels
3 - Done bug
Milestone
1.0.0

Comments

@pranavkm
Copy link
Contributor

Based on offline discussions with @davidfowl and @rynowak , the plan is to modify ICompilationLibrariesProvider to not expose CompilationLibrary instances instead returning a list of paths to reference assemblies.

An additional follow up was to return the assembly path in the event the assembly was compiled without preserveCompilationContext. This will unblock csproj based class library scenarios which do not have deps record.
pranavkm added a commit that referenced this issue May 25, 2016
@pranavkm
Modify ICompilationLibrariesProvider to remove a sequence of referenc…
b5351eb 
…e path

Fixes #4738
@pranavkm pranavkm mentioned this issue May 25, 2016
Closed
@Eilon Eilon added this to the 1.0.0 milestone May 25, 2016
@pranavkm pranavkm changed the title Modify ICompilationLibrariesProvider to remove a sequence of reference path strings Modify ICompilationLibrariesProvider to return a sequence of reference path strings May 25, 2016
pranavkm added a commit that referenced this issue May 25, 2016
@pranavkm
Modify ICompilationLibrariesProvider to return a sequence of referenc…
3b6d87c 
…e path

Fixes #4738
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@pranavkm @Eilon