MapAreaRoute constraint not escaped

[sebastienros]

On this line:

Mvc/src/Microsoft.AspNetCore.Mvc.Core/Builder/MvcAreaRouteBuilderExtensions.cs

Line 134 in a78f77a

constraintsDictionary["area"] = areaName;

The area is a string that is used for the defaults, and the constraints. But in the case of constrains the string is evaluated as a regular expression. In my case the are looks like "Orchard.Setup" which would make it not work as expected because of the dot.

[sebastienros]

I would like a solution when on this extension method the constraint would be built using a StringRouteConstraint to exactly match the string passed as the area name. That would be equivalent to a Regex escaped solution, with the perf gain.

[rynowak]

Good find

[iscifoni]

I would like to do this issue
i have a question, all the contraints are defined into Routing repository, the contraint StringRouteConstraint will be defined on it ? Or StringRouteConstraint will be defined internal class ?

[rynowak]

@iscifoni that's a good question

@Eilon - will we want MVC 1.1.0 to require routing 1.1.0? If we're going to add a constraint as general as this, it would be better to define it in routing, but that will make MVC require 1.1.0.

[Eilon]

MVC 1.1.x depending on Routing 1.1.x seems perfectly reasonable. Don't we need to do this for @kichalla 's RouteCreationException thing anyway?

[rynowak]

Yes we do.

Ok so @iscifoni - you'd want to add StringRouteConstraint to routing first, and then add usage of it to MVC.

@Eilon are you concerned about the breaking change behavior change here? We never intended to treat the area name as a regex.

[Eilon]

Yeah let's just fix this and have it be treated as a string. No idea why it was ever treated as a regex - I cannot possibly imagine that it was deliberate.

[rynowak]

Fixed by 6e5187c and aspnet/Routing@88de3d5