This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Using new StringRouteConstraint for area constraint #5119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ public void MapAreaRoute_Simple() | |||
| kvp => | |||
| { | |||
| Assert.Equal(kvp.Key, "area"); | |||
| Assert.IsType<RegexRouteConstraint>(kvp.Value); | |||
| Assert.IsType<StringRouteConstraint>(kvp.Value); | |||
There was a problem hiding this comment.
Would it be useful to check if the value in StringRouteConstraint is the original value (and not escaped in any way)?
|
🆙 📅 |
| @@ -9,6 +9,7 @@ | |||
| using Microsoft.Extensions.DependencyInjection; | |||
| using Moq; | |||
| using Xunit; | |||
| using Microsoft.AspNetCore.Http; | |||
|
LKGTM. I'll let @rynowak sign off on this. |
…NameAsIs - Sort using
|
🆙 📅 |
|
|
from me, I'll take care of merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4846 MapAreaRoute constraint not escaped
@rynowak @Eilon @sebastienros