When replacing Controller.Dispose with an explicit implementation the base Dispose is an action

[rynowak]

public class HomeController : Controller, IDisposable
{
        void IDisposable.Dispose()
        {
            Debug.WriteLine("Got disposed");
        }
}

If you define this controller, then /Home/Dispose will be routed to the Controller.Dispose() method and will call it as an action.

Note that this requires you to reimplement IDisposable on the subclass. Just overriding the protected void Dispose() would not have any deleterious impact.

This is a similar case that also reproduces the bug:

public class HomeController : Controller
{
        public new void Dispose()
        {
            Debug.WriteLine("Got disposed");
        }
}

[khellang]

Shouldn't this cover that last case? DerivedController (which is being tested) has this;

Mvc/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/DefaultApplicationModelProviderTest.cs

Lines 995 to 997 in b56cab6

	public new void Dispose()
	{
	}

[rynowak]

That covers the negative case. DerivedController.Dispose() should be considered an action since DerivedController doesn't declare IDisposable