Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Change the checkbox fork in InputTagHelper to work with other TagHelpers #5983

Closed
NTaylorMullen opened this issue Mar 17, 2017 · 1 comment
Closed

Comments

@NTaylorMullen
Copy link
Contributor

Today the GenerateCheckbox method in our InputTagHelper is inserted into the body of the TagHelperOutput. Functionally this works but it prevents other TagHelpers from acting on the current TagHelperOutput's tagname, attributes etc. We originally built the GenerateCheckbox impl as is because we'd always generate a hidden input tag inline; now, we have access to PostElement AND we have a separate TagHelper that renders the hidden input tag.

@dougbu
Copy link
Member

dougbu commented Apr 5, 2017

Think this is a dupe of #5902. As I mentioned in response to that bug, need to handle the !ViewContext.FormContext.CanRenderAtEndOfForm case. Guess we could instead find a way to require end of <form> rendering support.

jbagga added a commit that referenced this issue May 5, 2017
@jbagga jbagga closed this as completed May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants