Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

DefaultControllerFactory should throw if the controller is a value type #662

Closed
pranavkm opened this issue Jun 16, 2014 · 2 comments
Closed
Assignees
Milestone

Comments

@pranavkm
Copy link
Contributor

Might want to expand it to include more things (static \ abstract) etc and provide a meaningful message.

@Eilon
Copy link
Member

Eilon commented Apr 15, 2015

I'm not sure it's that important to throw for value types, because who would do that. But other cases such as generic types, abstract types, etc. we should look at to ensure we're safe and provide good errors.

@rynowak
Copy link
Member

rynowak commented Apr 15, 2015

Keep in mind that this will only happen if you build your own action descriptors. We already filter out all of these kinds of things during discovery.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants