This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Adding Unit Tests for XmlFormatters with DeclaredType as object. #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| [Theory] | ||
| [MemberData(nameof(BasicTypeValues))] | ||
| public async Task XmlDataContractSerializerOutputFormatterCanWriteBasicTypes(object input, string expectedOutput) |
There was a problem hiding this comment.
We should test CanWriteResult and GetSupportedContentTypes as well as WriteAsync
|
When @rynowak is happy |
sornaks
force-pushed
the
XmlUnitTests
branch
from
530c909 to
20698c3
Compare
|
Updated.. |
|
|
||
| // Act | ||
| var resultArray = formatter.GetSupportedContentTypes( | ||
| typeof(DummyClass), typeof(DummyClass), MediaTypeHeaderValue.Parse("application/xml")).AsArray(); |
There was a problem hiding this comment.
this doesn't test the difference between declaredType and runtimeType, which is what this bug is about
|
⌚ Discussed with Sorna in person, he's also going to add tests for #1081 to this PR |
|
Updated.. I separated the #1081 PR.. |
sornaks
force-pushed
the
XmlUnitTests
branch
from
4ecd5a9 to
ea7af0d
Compare
| // Assert | ||
| if (expectedOutput != null) | ||
| { | ||
| Assert.Equal(expectedOutput, (result.AsArray())[0].RawValue); |
There was a problem hiding this comment.
Assert.Equal(expectedOutput, Assert.Single(result).RawValue);
much clearer and validates something else that you care about
|
cleanup asserts and then |
|
Done. Thanks Ryan! Checked in - 96318dc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1072