This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Modify BuilderExtensions.UseMvc to not add any routes by default #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Adds Mvc to the <see cref="IApplicationBuilder"/> request execution pipeline. | ||
| /// </summary> | ||
| /// <param name="app">The <see cref="IApplicationBuilder"/> to add Mvc too.</param> | ||
| /// <returns>The <paramref name="app"/>.</returns> | ||
| public static IApplicationBuilder UseMvc([NotNull] this IApplicationBuilder app) |
There was a problem hiding this comment.
nit: should docs include <remarks/> describing expectation application uses attribute routes exclusively?
There was a problem hiding this comment.
Ehh, not super sure on this - remarks shouldn't be a place for specifying application design guidance. This sounds more like a sample \ doc thing
There was a problem hiding this comment.
Seems like we could say something here without it being design guidance.
UseMvc() only supports attribute routing. To add conventional routes use AddMvc(...).
|
|
after minor fixes
| /// <summary> | ||
| /// Adds Mvc to the <see cref="IApplicationBuilder"/> request execution pipeline. | ||
| /// </summary> | ||
| /// <param name="app">The <see cref="IApplicationBuilder"/> to add Mvc too.</param> |
There was a problem hiding this comment.
The to add Mvc too.
The <see cref="IApplicationBuilder"/>. IMO
|
Updated |
| @@ -4,7 +4,6 @@ | |||
| using Microsoft.AspNet.Builder; | |||
| using Microsoft.AspNet.Mvc; | |||
| using Microsoft.AspNet.Mvc.Xml; | |||
| using Microsoft.AspNet.Routing; | |||
There was a problem hiding this comment.
ah, so this'll go in after your Routing change?
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1879