This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Added InputFormatter base type #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| /// <param name="context">The <see cref="InputFormatterContext"/> associated with the call.</param> | ||
| /// <returns>A task which can read the request body.</returns> | ||
| public abstract Task<object> ReadRequestBodyAsync(InputFormatterContext context); | ||
| } |
There was a problem hiding this comment.
Should you also move the SelectCharacterEncoding method to this base class?...Ideally I would like to see a test where you create a custom formatter using this base type just to see how the experience would be like...currently that picture is missing...please update the PR with it..
There was a problem hiding this comment.
Moved. Will update tests shortly.
ajaybhargavb
force-pushed
the
input-formatter
branch
2 times, most recently
from
3fe347a to
a3f04aa
Compare
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="InputFormatter"/> class. | ||
| /// </summary> | ||
| protected InputFormatter() |
There was a problem hiding this comment.
don't need this constructor.
Instead see below comment
|
Lets discuss having the |
when comments are addressed and
| @@ -0,0 +1,111 @@ | |||
| using System; | |||
|
|
ajaybhargavb
force-pushed
the
input-formatter
branch
from
a3f04aa to
13e1c9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #1222
@yishaigalatzer @kichalla @harshgMSFT