This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Adding IView.Path and ViewContext.ExecutingPagePath #1996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
cc @DamianEdwards \ @dougbu |
| /// Asynchronously renders the view using the specified <paramref name="content"/>. | ||
| /// </summary> | ||
| /// <param name="context">The <see cref="ViewContext"/>.</param> | ||
| /// <returns>A <see cref="Task"/> rthat represents the asynchronous rendering.</returns> |
There was a problem hiding this comment.
- typo: "that"
- avoid "represents" since it's meaningless. suggest
A <see cref="Task"/> that on completion renders the view.
dougbu
changed the title
|
⌚ |
|
|
when 
|
Updated. |
|
I'm reluctant about the lambda property for a read only value. if you can hold off pushing, let's talk about that tomorrow. |
|
|
| public interface IView | ||
| { | ||
| /// <summary> | ||
| /// Gets the path of the view as resolved by the <see cref="ViewResult"/>. |
There was a problem hiding this comment.
doesn't this come from the view engine? there's nothing stopping you from using this outside of ViewResult
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1940