This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Removing IInputFormatterSelector #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -48,7 +47,7 @@ public BodyModelBinder() | |||
| return new ModelBindingResult(model: null, key: bindingContext.ModelName, isModelSet: false); | |||
| } | |||
|
|
|||
| object model = null; | |||
| object model; | |||
There was a problem hiding this comment.
You can safely move this all of the way into the try
|
|
pranavkm
force-pushed
the
InputFormatterSelector
branch
from
635bd34 to
6e21c2c
Compare
|
Updated with some dead code cleanup + new functional tests |
| } | ||
| catch (Exception ex) | ||
| { | ||
| model = GetDefaultValueForType(bindingContext.ModelType); | ||
| bindingContext.ModelState.AddModelError(bindingContext.ModelName, ex); | ||
|
|
||
| // This model binder is the only handler for the Body binding source. | ||
| // Always tell the model binding system to skip other model binders i.e. return non-null. | ||
| return new ModelBindingResult(model: null, key: bindingContext.ModelName, isModelSet: false); |
There was a problem hiding this comment.
This was my bad. I think the first parameter here was supposed to be assigned the default value for type model calculated above?
There was a problem hiding this comment.
- For action parameters,
MethodInfo.Invokeseems to take care of coercing null value types to default values for value types (this is verified by test). - For value type properties that are annotated with
[FromBody], we end up getting a null ref as part of the property setter. Tracking this via Value type controller properties with [From*] fail with NullRef exception when no value is available #2357.
That said, it seems like fixing it specifically for BodyModelBinder is incorrect and we should have a single top level piece of code that addresses this, not individual binders.
|
|
| @@ -127,6 +127,43 @@ public class InputFormatterTests | |||
| } | |||
|
|
|||
| [Theory] | |||
| [InlineData("\"I'm a JSON string!\"")] | |||
| [InlineData("true")] | |||
| public async Task JsonInputFormatter_ReturnsDefaultValue_ForValueTypes(string input) | |||
There was a problem hiding this comment.
How about an empty string content? that should be treated as a null value and a model state error should be added by JsonInputformatter
|
⌚ on one test case. |
Follow up work item to #2269
pranavkm
force-pushed
the
InputFormatterSelector
branch
from
6e21c2c to
43e24b2
Compare
|
Updated. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work item to #2269