This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Added path info to RazorPage exceptions #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -179,7 +179,7 @@ private bool EnableInstrumentation | |||
| // the body content. Throwing this exception wouldn't return a 500 (since content has already been | |||
| // written), but a diagnostic component should be able to capture it. | |||
|
|
|||
| var message = Resources.FormatLayoutCannotBeRendered("FlushAsync"); | |||
| var message = Resources.FormatLayoutCannotBeRendered(Path, "FlushAsync"); | |||
There was a problem hiding this comment.
nameof(RazorPage.FlushAsync) while you're here
There was a problem hiding this comment.
FlushAsync is not part of IRazorPage. So can't access it from here.
There was a problem hiding this comment.
the issue is the RazorPage property hiding the class. but nameof(Razor.RazorPage.FlushAsync) works.
|
⌚ |
|
Couple more places where we could print out the path:
|
|
Updated. |
| @@ -748,14 +748,14 @@ public Task<HtmlString> RenderSectionAsync([NotNull] string name) | |||
| // change. | |||
| if (_writerScopes.Count > 0) | |||
| { | |||
| throw new InvalidOperationException(Resources.RazorPage_YouCannotFlushWhileInAWritingScope); | |||
| throw new InvalidOperationException(Resources.FormatRazorPage_CannotFlushWhileInAWritingScope(nameof(FlushAsync), Path)); | |||
|
|
|
|
|
|
ajaybhargavb
force-pushed
the
render-body-fix
branch
from
509fd77 to
28d5df3
Compare
ajaybhargavb
force-pushed
the
render-body-fix
branch
from
28d5df3 to
f878ca5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #1919
The exception referenced by the issue has already been fixed.
I've updated few other exceptions in
RazorPageandRazorView.@Eilon @pranavkm