Preserve `ViewDataDictionary.ModelType` for `Nullable<T>` properties when `Model` is non-`null` #2988

dougbu · 2015-08-18T00:07:24Z

Changes to ModelMetadata provided by a ModelMetadataDetailsProvider are sometimes lost if the model property is a Nullable<T> #2539
reuse ModelMetadata and occasionally ModelExplorer when ModelType is Nullable<T>

…when `Model` is non-`null` - #2539 - reuse `ModelMetadata` and occasionally `ModelExplorer` when `ModelType` is `Nullable<T>`

dougbu · 2015-08-18T00:07:35Z

/cc @rynowak @pranavkm

rynowak · 2015-08-18T01:02:44Z

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewDataDictionary.cs

@@ -186,7 +186,9 @@ protected ViewDataDictionary([NotNull] ViewDataDictionary source, object model,
        {
            // This is the core constructor called when Model is known.
            var modelType = GetModelType(model);
-            if (modelType == source.ModelMetadata.ModelType && model == source.ModelExplorer.Model)
+            var metadataModelType =
+                Nullable.GetUnderlyingType(source.ModelMetadata.ModelType) ?? source.ModelMetadata.ModelType;


Should we hoist this to a property on ModelMetadata?

I like the idea but suggest doing this (and a bit more) as a follow-up. Filed #2992

rynowak · 2015-08-18T01:03:16Z

dougbu · 2015-08-18T17:49:52Z

f10a071

Preserve ViewDataDictionary.ModelType for Nullable<T> properties …

3601791

…when `Model` is non-`null` - #2539 - reuse `ModelMetadata` and occasionally `ModelExplorer` when `ModelType` is `Nullable<T>`

dnfclas added the cla-already-signed label Aug 18, 2015

rynowak reviewed Aug 18, 2015
View reviewed changes

dougbu closed this Aug 18, 2015

dougbu deleted the dougbu/nullable.viewdata.2539 branch August 18, 2015 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preserve `ViewDataDictionary.ModelType` for `Nullable<T>` properties when `Model` is non-`null` #2988

Preserve `ViewDataDictionary.ModelType` for `Nullable<T>` properties when `Model` is non-`null` #2988

dougbu commented Aug 18, 2015

dougbu commented Aug 18, 2015

rynowak Aug 18, 2015

dougbu Aug 18, 2015

rynowak commented Aug 18, 2015

dougbu commented Aug 18, 2015

Preserve ViewDataDictionary.ModelType for Nullable<T> properties when Model is non-null #2988

Preserve ViewDataDictionary.ModelType for Nullable<T> properties when Model is non-null #2988

Conversation

dougbu commented Aug 18, 2015

dougbu commented Aug 18, 2015

rynowak Aug 18, 2015

Choose a reason for hiding this comment

dougbu Aug 18, 2015

Choose a reason for hiding this comment

rynowak commented Aug 18, 2015

dougbu commented Aug 18, 2015

Preserve `ViewDataDictionary.ModelType` for `Nullable<T>` properties when `Model` is non-`null` #2988

Preserve `ViewDataDictionary.ModelType` for `Nullable<T>` properties when `Model` is non-`null` #2988