This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Revisit caching for RazorViewEngine #3364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly I won't get to this until later tonite. |
pranavkm
force-pushed
the
prkrishn/3337
branch
from
dfc48f3 to
3891494
Compare
|
🆙📅 |
|
9 days later, I'm getting to this 👍 |
| @@ -54,9 +55,10 @@ public CompilerCache(IFileProvider fileProvider) | |||
| throw new ArgumentNullException(nameof(precompiledViews)); | |||
| } | |||
|
|
|||
| var expirationTokens = new IChangeToken[0]; | |||
There was a problem hiding this comment.
Might be nice to add a comment calling out that we're explicitly calling out precompiled views as non-expiring
|
⌚ |
pranavkm
force-pushed
the
prkrishn/3337
branch
from
3891494 to
3507201
Compare
pranavkm
changed the title
pranavkm
force-pushed
the
prkrishn/3337
branch
2 times, most recently
from
87929b1 to
01064c7
Compare
pranavkm
force-pushed
the
prkrishn/3337
branch
from
01064c7 to
487e592
Compare
|
🆙 📅 |
|
11 days later I'm finally getting to this 👍 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3337