This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Special-case use of razorPage.Model property in ExpressionMetadataProvider
#4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @rynowak |
| @@ -70,7 +70,7 @@ | |||
| </div> | |||
| <div> | |||
| <label class="order" for="Customer_Gender">Gender</label> | |||
| <input type="radio" value="Male" data-val="true" data-val-required="The Model field is required." id="Customer_Gender" name="Customer.Gender" /> Male | |||
| <input type="radio" value="Male" data-val="true" data-val-required="The Gender field is required." id="Customer_Gender" name="Customer.Gender" /> Male | |||
There was a problem hiding this comment.
That's right -- we already had a functional test for this scenario. It was just looking for a broken error message.
|
⌚ for discussion on https://github.com/aspnet/Mvc/pull/4480/files#r59813906 |
|
|
…Provider` - #3978 - better-aligns `ExpressionMetadataProvider` with `ExpressionHelper` nit: mock less in `RazorPageCreateModelExpressionTest`
dougbu
force-pushed
the
dougbu/identity.expressions.3978
branch
from
59c4c26 to
25ac089
Compare
|
🆙📅 FYI only unless @rynowak hates tests I added in last commit. Will port to |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelExpressionequivalent ofm => m: Better supportasp-for="@Model"#3978ExpressionMetadataProviderwithExpressionHelpernit: mock less in
RazorPageCreateModelExpressionTest