This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Changed the form tag helpers execution order to be more explicit. #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -41,14 +41,10 @@ public FormTagHelper(IHtmlGenerator generator) | |||
| Generator = generator; | |||
| } | |||
|
|
|||
| // This taghelper's order must be lower than the RenderAtEndOfFormTagHelper. i.e It must be executed before | |||
There was a problem hiding this comment.
nit: TagHelper, same in other comment. Just for consistency 😄
|
|
1 similar comment
|
|
[Fixes #4824] Fix Travis failure for test Microsoft.AspNetCore.Mvc.FunctionalTests.TagHelpersTest.ReregisteringAntiforgeryTokenInsideFormTagHelper_DoesNotAddDuplicateAntiforgeryTokenFields
kichalla
force-pushed
the
kiran/ci-fix-order-formtaghelpers
branch
from
94f750b to
a2feeab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #4824] Fix Travis failure for test Microsoft.AspNetCore.Mvc.FunctionalTests.TagHelpersTest.ReregisteringAntiforgeryTokenInsideFormTagHelper_DoesNotAddDuplicateAntiforgeryTokenFields
@rynowak @dougbu @NTaylorMullen
Travis build succeeded: https://travis-ci.org/aspnet/Mvc/builds/136761441