This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Adding PageActionDescriptorProvider #5544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
force-pushed
the
prkrishn/PageActionDescriptorProvider
branch
from
10091f1 to
8d636bf
Compare
|
Bump, I'd like to get this in soon. |
rynowak
approved these changes
Nov 21, 2016
| /// <summary> | ||
| /// Application model component for RazorPages. | ||
| /// </summary> | ||
| public class PageModel |
There was a problem hiding this comment.
Filename here is wrong, PageModels.cs
| // Act and Assert | ||
| var ex = Assert.Throws<InvalidOperationException>(() => provider.OnProvidersExecuting(context)); | ||
| Assert.Equal( | ||
| "The @page directive for the Razor page at /Test.cshtml cannot override the relative path prefix.", |
There was a problem hiding this comment.
This is a really jargon-ey error. I'd suggest something like
The route for a page cannot start with
/or~/. Pages do not support overriding the file path of the page.
| "warningsAsErrors": true, | ||
| "compile": { | ||
| "include": "../Microsoft.AspNetCore.Mvc.TestCommon/TestFile*.cs" | ||
| } |
There was a problem hiding this comment.
I think I had some odd issues referencing TestCommon before we had rebased. I'll see if it's fixed now.
|
Looks good to me, but get @rynowak sign-off |
|
I did 😆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5353