Remove old razor #5977
Remove old razor #5977
Conversation
| @@ -16,6 +16,7 @@ | |||
| <ItemGroup> | |||
| <ProjectReference Include="..\Microsoft.AspNetCore.Mvc.Razor\Microsoft.AspNetCore.Mvc.Razor.csproj" /> | |||
|
|
|||
| <PackageReference Include="Microsoft.AspNetCore.Razor" Version="$(AspNetCoreVersion)" /> | |||
There was a problem hiding this comment.
Same question for others below
There was a problem hiding this comment.
These assemblies are still needed for Tag Helpers. What's important is that we need to remove usage of the old compiler types.
|
Looks like some tests such as |
|
Rebasing with dev should fix it 👍 |
| @@ -10,22 +10,18 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Internal | |||
| public class CompositeTagHelperDescriptorResolver : ITagHelperDescriptorResolver | |||
There was a problem hiding this comment.
Would we still need this type if all its doing is delegating to the inner one?
There was a problem hiding this comment.
I don't think so, but it's my understanding that we'll be adding the ViewComponentTagHelperDescriptorResolver back in, so I figured we didn't want to do too much work rearchitecting this in the meantime.
There was a problem hiding this comment.
The ITagHelperDescriptorResolver type here is going to be removed. Let's delete this and bring it back in Razour.
There was a problem hiding this comment.
We will need to remove this because ITagHelperDescriptorResolver is being removed
| var resolverDescriptor = Assert.Single(services.ToList(), d => d.ServiceType == typeof(ITagHelperTypeResolver)); | ||
| Assert.Equal(typeof(FeatureTagHelperTypeResolver), resolverDescriptor.ImplementationType); | ||
| // This was removed to facilitate the move to new razor and will be re-added as part of https://github.com/aspnet/Mvc/issues/5768 | ||
| //var resolverDescriptor = Assert.Single(services.ToList(), d => d.ServiceType == typeof(ITagHelperTypeResolver)); |
There was a problem hiding this comment.
Remove it for now. It's in the source control history if you need to look it up. Let's not leave commented out code.
| @@ -12,6 +12,7 @@ | |||
| <ProjectReference Include="..\Microsoft.AspNetCore.Mvc.TestCommon\Microsoft.AspNetCore.Mvc.TestCommon.csproj" /> | |||
|
|
|||
| <PackageReference Include="Microsoft.AspNetCore.Http" Version="$(AspNetCoreVersion)" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.Razor" Version="$(AspNetCoreVersion)" /> | |||
There was a problem hiding this comment.
Why does the test need an explicit reference?
ryanbrandenburg
force-pushed
the
rybrande/RemoveOldRazor
branch
2 times, most recently
from
0e09ef5 to
7db0bee
Compare
as long as the tests are passing 👍
ryanbrandenburg
force-pushed
the
rybrande/RemoveOldRazor
branch
from
8afcd7b to
270f661
Compare
Remove usages of old razor.