This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Update how FormTagHelper handles get method attributes.
#6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added functional test to verify `asp-*` attributes on form taghelpers work as expected. - Added a unit test to validate `FormTagHelper` behaves as expected. - Moved `Method == "get"` checks into appropriate code paths. These include the one where a user specifies an empty or non-existent `action` attribute and where a user doesn't utilize any `asp-*` attributes. In the later, we default `Method` to `"get"` if it's not provided. #6006
NTaylorMullen
force-pushed
the
nimullen/6006.p3
branch
from
7402935 to
7dc9543
Compare
|
@dougbu signed off on this in person. Will merge once I verify things build successfully locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asp-*attributes on form taghelpers work as expected.FormTagHelperbehaves as expected.Method == "get"checks into appropriate code paths. These include the one where a user specifies an empty or non-existentactionattribute and where a user doesn't utilize anyasp-*attributes. In the later, we defaultMethodto"get"if it's not provided.#6006
@dougbu had to do a few extra changes than the ones I showed you; therefore, here's the review 👍 .