Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

RazorPages page directives missing quotes should alert user #6434

Merged
merged 1 commit into from
Jun 22, 2017
Merged

RazorPages page directives missing quotes should alert user #6434

merged 1 commit into from
Jun 22, 2017

Conversation

pranavkm
Copy link
Contributor

Fixes #5868

pranavkm
pranavkm commented Jun 22, 2017
View reviewed changes
test/Microsoft.AspNetCore.Mvc.RazorPages.Test/Infrastructure/PageDirectiveFeatureTest.cs
}

[Fact]
public void TryGetPageDirective_JunkBeforeNewline()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just testing parser behavior. We shouldn't need separate tests for it here.

test/Microsoft.AspNetCore.Mvc.RazorPages.Test/Infrastructure/PageDirectiveFeatureTest.cs
}

[Fact]
public void TryGetPageDirective_NullProject()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eww tests

src/Microsoft.AspNetCore.Mvc.RazorPages/Infrastructure/PageDirectiveFeature.cs
}

public static bool TryGetPageDirective(Func<Stream> streamFactory, out string template)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused now. Formerly used by precompilation.

@pranavkm
Copy link
Contributor Author

What this looks like:

info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5000/
warn: Microsoft.AspNetCore.Mvc.RazorPages.Internal.RazorProjectPageApplicationModelProvider[104]
      The page directive at '\Mvc\samples\MvcSandbox\Pages\PagesHome.cshtml' is malformed. Please fix the following issues: The 'page' directive expects a string surrounded by double quotes.

@pranavkm pranavkm merged commit 0dfffd4 into dev Jun 22, 2017
@pranavkm pranavkm deleted the prkrishn/5868 branch June 22, 2017 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rynowak rynowak rynowak approved these changes

@NTaylorMullen NTaylorMullen Awaiting requested review from NTaylorMullen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @rynowak @dnfclas