This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
_ViewStart.cshtml not picked up when added to the root of the app #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Jun 22, 2017
| @@ -210,8 +207,11 @@ private InnerCache CurrentCache | |||
| internal List<Func<IRazorPage>> GetViewStartFactories(CompiledPageActionDescriptor descriptor) | |||
| { | |||
| var viewStartFactories = new List<Func<IRazorPage>>(); | |||
| // Always pick up all _ViewStarts, including the ones outside the Pages root. This mirrors the | |||
| // behavior of _ViewImports.cshtml discovery. | |||
There was a problem hiding this comment.
This is consistent with views yes?
There was a problem hiding this comment.
Ahh, there's another overload that does not take basePath (which is what we use in the view engine). I'll switch to it.
rynowak
approved these changes
Jun 22, 2017
NTaylorMullen
approved these changes
Jun 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6308