This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Making Pages Binding Consistent #6444
Merged
+346
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @pranavkm - this is for you |
pranavkm
approved these changes
Jun 26, 2017
| { | ||
| get | ||
| { | ||
| return SupportsGet ? (ActionContext c) => true : (Func<ActionContext, bool>)IsNonGetRequest; |
There was a problem hiding this comment.
Cache the delegates as statics?
| foreach (var requestPredicateProvider in attributes.OfType<IRequestPredicateProvider>()) | ||
| { | ||
| isBindingInfoPresent = true; | ||
| bindingInfo.RequestPredicate = requestPredicateProvider.RequestPredicate; |
There was a problem hiding this comment.
Should this break after the first item (similar to BindingSource)? It's picking predicate arbitrarily anyway
| { | ||
| /// <summary> | ||
| /// An interface that allows a top-level model to be bound or not bound based on state assocated | ||
| /// with the current request. |
There was a problem hiding this comment.
No, I mean the concept of a current request.
Yes. Pages and controllers now both behave as you described above. |
rynowak
force-pushed
the
rynowak/binding-enhancements
branch
from
9036165 to
0ad9c7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset reckonciles the binding work we did for pages with
controllers.
A quick summary: